✨ s3: allow best effort delete for objects #4904
Conversation
This change introduces a new config option for `S3Bucket` to allow best effort delete for S3 objects. This is useful to not fail cluster installs when the user has policies in place that prevent object deletion.
k8s-ci-robot
added
release-note
|
Hi @r4f4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/retitle ✨ s3: allow best effort delete for objects |
|
@r4f4: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
r4f4
changed the title
Ankitasw
added
ok-to-test
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
If `S3Bucket.BestEffortDeleteObjects` is present and true,
`AccessDenied` errors will be ignored when deleting S3 objects. This is
useful when a user installs a clusters in an account with policies in
place to prevent object deletion, e.g:
```
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "Deny object deletions",
"Effect": "Deny",
"Principal": "*",
"Action": "s3:DeleteObject",
"Resource": "arn:aws:s3:::<bucketname>/*"
}
]
}
```
Such errors should not prevent a successful install.
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@Ankitasw I've addressed your feedback points. Can you take another look? |
|
@richardcase any comments on this? |
|
/test ? |
|
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-aws-e2e |
|
From my side this looks good /approve Until the e2e pass: /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-provider-aws-e2e |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-aws-e2e |
2 similar comments
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-e2e |
|
@richardcase I think we're ready to remove the hold. |
|
Considering the comment from @richardcase Given E2Es are green let's unhold this |
k8s-ci-robot
removed
the
do-not-merge/hold
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change introduces a new config option for
S3Bucketto allow best effort delete for S3 objects. This is useful to not fail cluster installs when the user has policies in place that prevent object deletion.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4903
Special notes for your reviewer:
Checklist:
Release note: