-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update Go version to 1.22.6 #5078
Conversation
/assign @damdo @richardcase |
Should we update the go version in the other places as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already included it in https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5061/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R23
But if we want to do that early that's ok too, as I see this is failing on other PRs so we might not want to wait for 5061
/lgtm
Will update some of these, but fwiw the go.mod can be left alone unless we're using Go 1.22-specific features. |
It looks like this is now blocking other PRs as the verify job is permafailing until this merges. cc. @nrb |
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@damdo @richardcase Updated Go version in all the relevant places I could find. Also bumped to the latest patch release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind support
What this PR does / why we need it:
Updates to Go 1.22 in order to account for updated Go module toolchain behaviors.
Special notes for your reviewer:
Checklist:
Release note: