Add permissions to the GitHub Actions token #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
nrb
force-pushed
the
github-actions-fix
branch
from
5e0f2b4
to
cc13922
Compare
|
The values for this PR come from a similar one in CAPI |
k8s-ci-robot
added
the
lgtm
|
Also - GitHub won't pick up the new values from this PR until it's merged, as a safety measure against attacks (so that random users can't open a PR and export secrets). |
* Dependabot needs to be able to update PRs it creates * The pr-verify job needs to be able to write to the checks API Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
nrb
force-pushed
the
github-actions-fix
branch
from
cc13922
to
e1e078b
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndiDog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Manually merging at OWNERS request as this is to address the failing GH action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since moving to the Kubernetes GitHub Enterprise account, our GitHub Actions jobs haven't been able to write their status to the API.
This results in the following error on all jobs that run within GitHub Actions:
Special notes for your reviewer:
This is similar to the permissions carried by upstream CAPI
Release note: