Bump opentelemetry-go to v1.28.0/v0.50.0 #5114
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5114 +/- ##
=======================================
Coverage 51.25% 51.25%
=======================================
Files 273 273
Lines 24651 24651
=======================================
Hits 12636 12636
Misses 11229 11229
Partials 786 786 ☔ View full report in Codecov by Sentry. |
|
/hold This needs manual testing with Tilt. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retest |
| @@ -172,7 +172,7 @@ require ( | |||
| github.com/peterbourgon/diskv v2.0.1+incompatible // indirect | |||
| github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect | |||
| github.com/prometheus/client_model v0.6.1 // indirect | |||
| github.com/prometheus/common v0.54.0 // indirect | |||
| github.com/prometheus/common v0.55.0 // indirect | |||
There was a problem hiding this comment.
I suspect this doesn't affect our ability to drop the replace for this module?
There was a problem hiding this comment.
We could drop the replace, but as soon as it moves past v0.47.0 we run into
github.com/prometheus/client_golang/prometheus/testutil/promlint
../../go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText
and removing that replace just kicks the same error over to component-base. I think it's fixed in component-base v0.31.0 but that's jumping ahead of other k8s vendoring. So it's probably safest to leave the replaces intact for now.
There was a problem hiding this comment.
Cool, that's what I was expecting. Thanks for checking!
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fef332ba24ee5714b2979537d01f2d8796b4fedf
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates opentelemetry-go to the v1.28.0/v0.50.0 release.
Which issue(s) this PR fixes:
Refs #4860
Special notes for your reviewer:
TODOs:
Release note: