-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep stable order of agent pool profiles when reconciling managed cluster #5137
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5137 +/- ##
==========================================
+ Coverage 51.25% 51.26% +0.01%
==========================================
Files 273 273
Lines 24651 24654 +3
==========================================
+ Hits 12634 12639 +5
+ Misses 11231 11229 -2
Partials 786 786 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b38ffa197f4c2d3beb528d55f20a31c310ef3fbf
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When we first list the agent pools associated with a managed cluster to include them for the initial create, the nondeterministic order of the list causes some unnecessary updates to the ManagedCluster ASO resource. This change sorts the agent pools by name in the final ASO spec to ensure no unnecessary updates are made.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: