-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cluster API 1.5.3 #100
Conversation
this change updates the dependencies and fixes a minor issue in the code.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is following changes to upstream to make it follow the xdg configuration directory. see kubernetes-sigs/cluster-api#6913 for more information.
it took some modifications, but i've updated everything to use kube 1.27 and capi 1.5, here is the resultant cluster that was created after i applied cni
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
(not sure if you squash commits on this repo, but feel free to unhold if it's okay)
thanks @killianmuldoon ! we haven't been squashing commits here, not for any specific reason other than perhaps laziness and the testing nature of this provider. /hold cancel |
What this PR does / why we need it:
update the provider to use CAPI 1.5.3
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #93
Special notes for your reviewer:
Release notes: