Lint

test/framework/autoscaler_helpers.go

@@ -166,9 +166,9 @@ func AddScaleUpDeploymentAndWait(ctx context.Context, input AddScaleUpDeployment
 	replicas := workers + 1
 	memoryRequired := int64(float64(memory.Value()) * 0.6)
 	podMemory := resource.NewQuantity(memoryRequired, resource.BinarySI)
-	deploymentName := input.Name
-	if deploymentName == "" {
-		deploymentName = "scale-up"
+	deploymentName := "scale-up"
+	if input.Name != "" {
+		deploymentName = input.Name
 	}
 
 	scaleUpDeployment := &appsv1.Deployment{
@@ -228,12 +228,12 @@ type DeleteScaleUpDeploymentAndWaitInput struct {
 }
 
 // DeleteScaleUpDeploymentAndWait deletes the scale up deployment and waits for it to be deleted.
-func DeleteScaleUpDeploymentAndWait(ctx context.Context, input DeleteScaleUpDeploymentAndWaitInput) error {
+func DeleteScaleUpDeploymentAndWait(ctx context.Context, input DeleteScaleUpDeploymentAndWaitInput) {
 	By("Retrieving the scale up deployment")
 	deployment := &appsv1.Deployment{}
-	deploymentName := input.Name
-	if deploymentName == "" {
-		deploymentName = "scale-up"
+	deploymentName := "scale-up"
+	if input.Name != "" {
+		deploymentName = input.Name
 	}
 	Expect(input.ClusterProxy.GetClient().Get(ctx, client.ObjectKey{Name: deploymentName, Namespace: metav1.NamespaceDefault}, deployment)).To(Succeed(), "failed to get the scale up pod")
 
@@ -249,7 +249,6 @@ func DeleteScaleUpDeploymentAndWait(ctx context.Context, input DeleteScaleUpDepl
 		}
 		return nil
 	}, input.WaitForDelete...).Should(BeNil())
-	return nil
 }
 
 type ProcessYAMLInput struct {