🐛 Allow KCP spec.version to be mutable

Signed-off-by: Vince Prignano <vincepri@vmware.com>
kubernetes-sigs · Mar 8, 2020 · 992f410 · 992f410
1 parent 4d0192c
commit 992f410
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go b/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go
@@ -77,6 +77,7 @@ func (in *KubeadmControlPlane) ValidateUpdate(old runtime.Object) error {
 		{spec, kubeadmConfigSpec, clusterConfiguration, "etcd", "local", "imageTag"},
 		{spec, "infrastructureTemplate", "name"},
 		{spec, "replicas"},
+		{spec, "version"},
 	}
 
 	allErrs := in.validateCommon()

diff --git a/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go b/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go
@@ -174,6 +174,7 @@ func TestKubeadmControlPlaneValidateUpdate(t *testing.T) {
 
 	validUpdate := before.DeepCopy()
 	validUpdate.Labels = map[string]string{"blue": "green"}
+	validUpdate.Spec.Version = "v1.16.6"
 	validUpdate.Spec.InfrastructureTemplate.Name = "orange"
 	validUpdate.Spec.Replicas = pointer.Int32Ptr(5)