Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine Health Checking tracking issue #1990

Closed
7 tasks done
enxebre opened this issue Jan 3, 2020 · 8 comments
Closed
7 tasks done

Machine Health Checking tracking issue #1990

enxebre opened this issue Jan 3, 2020 · 8 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@enxebre
Copy link
Member

enxebre commented Jan 3, 2020

Machine Health Checking implementation

Implements #1684

Foundational patterns

  • Merge new types
    • MachineHealthCheck
    • MachineHealthCheckList
    • MachineHealthCheckSpec
    • UnhealthyCondition
    • MachineHealthCheckStatus
  • Merge Minimal reconciling skeleton logic unit tested

Logic Implementation

  • Flesh out unit tested reconciler logic to get targets from a MHC resource and health check them.
  • Flesh out unit tested remediation logic.
  • Add MachineHealthCheckReconciler with SetupWithManager to main.go.
  • Add docs
  • Add e2e tests
@vincepri
Copy link
Member

vincepri commented Mar 2, 2020

@enxebre do we need to keep this tracking issue open or did you want to close it?

@enxebre
Copy link
Member Author

enxebre commented Mar 2, 2020

hey @vincepri I think we still need to add e2e tests and docs for MHC, however you prefer to track it works for me.

@vincepri
Copy link
Member

vincepri commented Mar 2, 2020

do you think we can get the documentation and e2e in v0.3.0 or should we move it to v0.3.x?

@JoelSpeed
Copy link
Contributor

@vincepri Could you remind me when the cutoff is for 0.3.0? I'm working on the e2e tests tomorrow and the docs likely later this week, not sure when they'll be ready for merge though

@vincepri
Copy link
Member

vincepri commented Mar 2, 2020

It's set for March 10th, it sounds like we can definitely point this to v0.3.x given that's mostly for testing and docs

@vincepri
Copy link
Member

vincepri commented Mar 6, 2020

/milestone v0.3.x

@vincepri
Copy link
Member

Closing this now that all tasks have been completed
/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

Closing this now that all tasks have been completed
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants