Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl local repository mode does not handle windows paths #2658

Closed
vuil opened this issue Mar 12, 2020 · 0 comments · Fixed by #2661
Closed

clusterctl local repository mode does not handle windows paths #2658

vuil opened this issue Mar 12, 2020 · 0 comments · Fixed by #2661
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug.

Comments

@vuil
Copy link

vuil commented Mar 12, 2020

What steps did you take and what happened:
When setting up a local repository provider on windows and using windows style paths like so

providers:
  - name: cluster-api
    url: c:\Users\foo\.tkg\providers\cluster-api\v0.3.0\core-components.yaml
    type: CoreProvider
  - name: aws
    url: c:\Users\foo\.tkg\providers\infrastructure-aws\v0.5.0\infrastructure-components.yaml
    type: InfrastructureProvider
...

When using GetClusterTemplate to obtain a cluster template, an error is reported by clusterctl:

invalid provider url. there are no provider implementation for "c" schema"

because the url parsing library is interpreting c: as start of a url scheme

When using the file:/// scheme on windows like so

providers:
  - name: cluster-api
    url: file:///c:/Users/foo/.tkg/providers/cluster-api/v0.3.0/core-components.yaml
    type: CoreProvider
  - name: aws
    url: file:///c:/Users/foo/.tkg/providers/infrastructure-aws/v0.5.0/infrastructure-components.yaml
    type: InfrastructureProvider

we encounter another error from clusterctl library

"file:///c:/Users/foo/.tkg/providers/infrastructure-vsphere/v0.6.0/infrastructure-components.yaml" must be an absolute path

What did you expect to happen:
clusterctl library should be able to process some path format that works for windows file systems.

Anything else you would like to add:
no
Environment:

Cluster-api version:
/kind bug
/area clusterctl
/cc @fabriziopandini

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/clusterctl Issues or PRs related to clusterctl labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants