Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KCP] Increase unit test coverage #2779

Closed
sedefsavas opened this issue Mar 25, 2020 · 12 comments
Closed

[KCP] Increase unit test coverage #2779

sedefsavas opened this issue Mar 25, 2020 · 12 comments
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@sedefsavas
Copy link

sedefsavas commented Mar 25, 2020

Following issue #2753, this issue is to track unit-test-coverage increase efforts.
There are several TODO unit tests are added to the test files.
We should focus on improving the current coverage which is as follows:

kubeadm/controllers:

controller.go | 56.2% statements
helpers.go | 63.8% statements
scale.go | 59.2% statements
status.go | 82.8% statements
upgrade.go | 59.5% statements

kubeadm/internal:

etcd | 0% files, 0% statements
cluster.go | 8.6% statements
control_plane.go | 53.8% statements
etcd_client_generator.go | 0% statements
failure_domain.go | 0% statements
kubeadm_config_map.go | 16.9% statements
machine_collection.go | 90.2% statements
workload_cluster.go | 2.8% statements
workload_cluster_coredns.go | 76.8% statements

@sedefsavas
Copy link
Author

/area control-plane
/milestone v0.3.x
/priority critical-urgent

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/area control-plane
/milestone v0.3.x
/priority critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/control-plane Issues or PRs related to control-plane lifecycle management priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 25, 2020
@sedefsavas
Copy link
Author

cc @wfernandes @fabriziopandini

@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 25, 2020
@nader-ziada
Copy link
Contributor

Since this seems like a bit of work, I suggest we split the work by folder so multiple people can work on it

for example, I can start working on some of the internal files without tests while someone else can pick other packages if they want to

@sedefsavas
Copy link
Author

Good idea @nader-ziada
I will focus on scale and upgrade tests.

@wfernandes
Copy link
Contributor

/assign
@nader-ziada What files are you going to work on specifically?
I was thinking of workload_cluster* and moving onto kubeadm_config_map*

@nader-ziada
Copy link
Contributor

i'll take these

etcd | 0% files, 0% statements
cluster.go | 8.6% statements
control_plane.go | 53.8% statements
etcd_client_generator.go | 0% statements

@wfernandes
Copy link
Contributor

Are there any more areas that require testing in KCP? Should we close this issue?

@vincepri
Copy link
Member

vincepri commented Apr 9, 2020

We can probably close this for now, we're tacking the rest in #2753

/close

@vincepri
Copy link
Member

vincepri commented Apr 9, 2020

/milestone v0.3.4

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

We can probably close this for now, we're tacking the rest in #2753

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.3.4 Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

5 participants