Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated DeleteNodeAnnotation #2944

Closed
wfernandes opened this issue Apr 21, 2020 · 14 comments
Closed

Remove deprecated DeleteNodeAnnotation #2944

wfernandes opened this issue Apr 21, 2020 · 14 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
v0.4

Comments

@wfernandes
Copy link
Contributor

We've marked DeleteNodeAnnotation for deprecation as part of this PR #2929.

This issue is to track its removal.

/kind cleanup
/milestone v0.4.0
@k8s-ci-robot
Copy link
Contributor

@wfernandes: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

We've marked DeleteNodeAnnotation for deprecation as part of this PR #2929.

This issue is to track its removal.

/kind cleanup
/milestone v0.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 21, 2020
@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Apr 21, 2020
@detiber
Copy link
Member

detiber commented Apr 21, 2020

@elmiko this will have implications for the cluster autoscaler integration

@elmiko
Copy link
Contributor

elmiko commented Apr 21, 2020

thanks for the heads up @detiber, it certainly will!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2020
@elmiko
Copy link
Contributor

elmiko commented Jul 20, 2020

i think this is still active, maybe someone can correct me if that's not the case.
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2020
@detiber
Copy link
Member

detiber commented Jul 21, 2020

Indeed, this is still applicable
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 21, 2020
@vincepri
Copy link
Member

vincepri commented Feb 8, 2021

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 8, 2021
@furkatgofurov7
Copy link
Member

@vincepri this seems a duplication of #3954 and there was #3955 to fix it. However, we might need to backport it to release-0.3, and I can take care of it if needed.

@fabriziopandini
Copy link
Member

AFAIK removal of deprecated features should not be backported

@furkatgofurov7
Copy link
Member

@fabriziopandini in that case, this can be closed as it is a duplication, IMO.

@fabriziopandini
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
8 participants
@elmiko @detiber @wfernandes @vincepri @fabriziopandini @k8s-ci-robot @fejta-bot @furkatgofurov7