Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use systemd cgroupDriver in CAPD #4621

Closed
sbueringer opened this issue May 14, 2021 · 13 comments · Fixed by #6513
Closed

Use systemd cgroupDriver in CAPD #4621

sbueringer opened this issue May 14, 2021 · 13 comments · Fixed by #6513
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@sbueringer
Copy link
Member

User Story

As a operator I would like to use the (kubeadm) default cgroupDriver (which is systemd) with CAPD.

Detailed Description

Starting with kubeadm 1.21 the default cgroupDriver is systemd. With the upcoming kind version we have to pin CAPD to cgroupDriver cgroupsfs, because it won't work otherwise.

More context:

Anything else you would like to add:

Goal is essentially to revert #4614 once kubernetes-sigs/kind#1726 has been implemented and is usable for us.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2021
@sbueringer
Copy link
Member Author

sbueringer commented May 14, 2021 •
edited
Loading

/are testing

@sbueringer
Copy link
Member Author

/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label May 14, 2021
@fabriziopandini
Copy link
Member

For track of records I'm reporting here some some of my notes about the discussion that lead to opening this issue.

  • We should to stick to kind default, because kind's team is doing an amazing job in hardening the kindest/node image (this is why we implemented and 🌱 test/e2e: pin cgroupDriver to cgroupfs #4614).
  • We are going to wait for kind to switch to systemd cgroupDriver, and possibly, we should figure out a way to help in making this happen

@vincepri
Copy link
Member

/milestone Next

@k8s-ci-robot k8s-ci-robot added this to the Next milestone May 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2021
@fabriziopandini
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2021
@sbueringer
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2022
@sbueringer
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

We still want to go back to systemd when it's possible.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 14, 2022
@sbueringer
Copy link
Member Author

kubernetes v1.24.0+ and kind v0.13.0+ will do this.
kubernetes-sigs/kind#1726 (comment)

@fabriziopandini
Copy link
Member

@sbueringer thanks this is good news.
Might be also an opportunity to start using version-aware patches across the board.

@sbueringer sbueringer mentioned this issue May 11, 2022
Closed
@sbueringer
Copy link
Member Author

Just fyi, we might have to implement this in #6480 to get v1.24 to work.

@sbueringer sbueringer mentioned this issue May 12, 2022
Closed
@chrischdi chrischdi mentioned this issue May 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Use Kubernetes 1.24 in quickstart and CAPD, bump to kind v0.14 chrischdi/cluster-api
5 participants
@vincepri @sbueringer @fabriziopandini @k8s-ci-robot @k8s-triage-robot