Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to v1.21.0 #9149

Closed
furkatgofurov7 opened this issue Aug 8, 2023 · 7 comments
Closed

Bump Go to v1.21.0 #9149

furkatgofurov7 opened this issue Aug 8, 2023 · 7 comments
Labels
area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Aug 8, 2023

What would you like to be added (User Story)?

Golang v1.21.0 is out.

To read the release notes, check: https://go.dev/doc/go1.21.

We could already start using it, unless there are no objections :)

Detailed Description

Bump go version in main and possibly in release branches to v1.21.0

Anything else you would like to add?

Part of: #9094 (Bumping go version continously)

Label(s) to be applied

/kind feature
/area dependency

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2023
@furkatgofurov7
Copy link
Member Author

@kubernetes-sigs/cluster-api-release-team

cc @killianmuldoon @sbueringer

@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2023
@sbueringer
Copy link
Member

I think we should not use it until Kubernetes does it and they chose to not pick it up for Kubernetes 1.28.

Usually this is part of our Kubernetes upgrade issue for that reason (#8708)

xref: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1691508336469659

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Aug 9, 2023

@sbueringer I agree and k8s not using it probably there is not much left until 1.28 is out . Probably they start using it later in 1.28 patch releases, but until then we can hold this and come back again later (or feel free to close it if this is tracked in #8708 already).

@sbueringer
Copy link
Member

Looks like they are planning to bump in January

we should update master to it once it opens for 1.29, we should be ready to update release branches to it in January (1 month after 1.29 release), before go1.20 hits EOL in Feb
https://kubernetes.slack.com/archives/CJH2GBF7Y/p1691512908396339?thread_ts=1691508336.469659&cid=CJH2GBF7Y

I think for now we should continue with our usual model to bump Go when we pick up new Kubernetes versions (and don't pick it up later).

To change this model and align to what k/k is doing now I've opened this issue a while back: #7974

So I think if we want to start bumping Go later in the cycle and on release branches we have to make progress on #7974

@sbueringer
Copy link
Member

I would close it here for now until our bump "policies" change

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

I would close it here for now until our bump "policies" change

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants