Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix link to v1alpha4 types #10068

Merged
merged 1 commit into from
Jan 29, 2024
Merged

🐛 Fix link to v1alpha4 types #10068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/proposals/20181121-machine-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ performed in-place or via Node replacement.
## Proposal

This proposal introduces a new API type: Machine. See the full definition in
[machine_types.go](../../api/v1alpha4/machine_types.go).
[machine_types.go](https://github.com/kubernetes-sigs/cluster-api/blob/release-0.4/api/v1alpha4/machine_types.go).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to link to the same generation of types the proposal was talking about.


A "Machine" is the declarative spec for a Node, as represented in Kubernetes
core. If a new Machine object is created, a provider-specific controller will
Expand Down Expand Up @@ -142,4 +142,4 @@ revisit the specifics when new patterns start to emerge in core.

## Types

Please see the full types [here](../../api/v1alpha4/machine_types.go).
Please see the full types [here](https://github.com/kubernetes-sigs/cluster-api/blob/release-0.4/api/v1alpha4/machine_types.go).
Loading