-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [release-1.6] Promote chrischdi to Cluster API maintainer #10089
🌱 [release-1.6] Promote chrischdi to Cluster API maintainer #10089
Conversation
/cherry-pick release-1.5 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is the owners file branch specific? i.e do you not have approve rights on release-1.6 currently?
I wasn't aware we had to update older branches like this.
/lgtm
/approve
/hold
LGTM label has been added. Git tree hash: e316836f9558e2350032832b714a15a27692ee33
|
Hmm good question 🤔 cc @sbueringer I thought this was required 😂 |
I hope it's not - otherwise we should really be doing this on all branches - even ones that are completely out of date IMO. |
Prow takes the OWNERS files from the branch you want to merge into. It has to, the folder structure could be entirely different. In my opinion it's good enough to backport into active branches. There are still a lot of folks around who have approval rights on very old branches. In any case. We have enough permissions on the repo, we can merge in every branch we want if necessary. |
/lgtm @chrischdi Feel free to prove it by trying to approve the release-1.5 cherry-pick :D |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrischdi: new pull request created: #10090 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of #9997
/area community-meeting
/assign sbueringer
/cherry-pick release-1.5