Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump github.com/distribution/reference from 0.5.0 to 0.6.0 #10373

Closed
wants to merge 1 commit into from
Closed

🌱 Bump github.com/distribution/reference from 0.5.0 to 0.6.0 #10373

wants to merge 1 commit into from

Conversation

prashantrewar
Copy link

What this PR does / why we need it:
Bumps github.com/distribution/reference from 0.5.0 to 0.6.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10351

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @prashantrewar!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @prashantrewar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prashantrewar prashantrewar changed the title Bump github.com/distribution/reference from 0.5.0 to 0.6.0 🌱 Bump github.com/distribution/reference from 0.5.0 to 0.6.0 Apr 4, 2024
@prashantrewar prashantrewar mentioned this pull request Apr 4, 2024
Closed
neolit123
neolit123 reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area dependency
/ok-to-test

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-area PR is missing an area label labels Apr 4, 2024
@chrischdi
Copy link
Member

Requires a make generate-modules

also: fixes for the failing tests.

@sbueringer
Copy link
Member

sbueringer commented Apr 4, 2024 •
edited
Loading

That is strange. That's something the bot already did on the dependabot PR
(maybe we actually have to run it twice? o.O)

@prashantrewar
Bump github.com/distribution/reference from 0.5.0 to 0.6.0
4f44cfb 
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar
Copy link
Author

/test pull-cluster-api-test-main

@k8s-ci-robot
Copy link
Contributor

@prashantrewar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-test-main 4f44cfb link true /test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member

I think the generate-modules came from:

@prashantrewar
Copy link
Author

I think the generate-modules came from:

@chrischdi, I apologize but I didn't get this.

@chrischdi
Copy link
Member

I think the generate-modules came from:

@chrischdi, I apologize but I didn't get this.

The reason that you had to run make generate-modules to fix go.mod files was that the above PR merged to main.

What's still left for this PR is to take a look on why the tests at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10373/pull-cluster-api-test-main/1775860189065383936 fail and fix them.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

@chrischdi do you have time to take this one over?
We should bump ASAP

@sbueringer
Copy link
Member

@prashantrewar Are you planning to work on this?

@chrischdi chrischdi mentioned this pull request Apr 24, 2024
Merged
@chrischdi
Copy link
Member

/close in favor of #10501

@chrischdi
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prashantrewar prashantrewar deleted the bump-version branch April 25, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@elmiko elmiko Awaiting requested review from elmiko

@richardcase richardcase Awaiting requested review from richardcase

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashantrewar @k8s-ci-robot @chrischdi @sbueringer @neolit123