-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add compare util using go-cmp, modify webhooks & KCP controller #10628
🌱 Add compare util using go-cmp, modify webhooks & KCP controller #10628
Conversation
Not sure what the right areas are (apart from KCP) |
/test pull-cluster-api-e2e-main |
be2b7ae
to
677625c
Compare
/test pull-cluster-api-e2e-main |
d7b3d5c
to
8276336
Compare
/test pull-cluster-api-e2e-main |
/assign @chrischdi @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit
8276336
to
0e6aae2
Compare
/test pull-cluster-api-e2e-main |
/lgtm (failing test though) |
LGTM label has been added. Git tree hash: 1cbb61b35cb32a436cb37ed94cbe31e05798a4c7
|
0e6aae2
to
bccf748
Compare
Ups, thx, fixed |
/test pull-cluster-api-e2e-main |
/lgtm |
LGTM label has been added. Git tree hash: c6142679f413cf7869f87d9fd3f3cf2730468d37
|
Signed-off-by: Stefan Büringer buringerst@vmware.com
bccf748
to
57dc231
Compare
Had to rebase because of the defaulting webhook fix /assign @fabriziopandini @chrischdi |
/lgtm |
LGTM label has been added. Git tree hash: 3dd034826d867dd90f918d23537ea8663305d1ec
|
/assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This will greatly improve debugging rollouts in the logs
/lgtm
/approved
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Needs a bit more work and some manual tests (want to see how the diffs are looking in logs)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8186
Example logs for KCP controller
Message after removing escaping
Example for webhook