-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add remediation strategy support in MachineDeployment #10712
✨ Add remediation strategy support in MachineDeployment #10712
Conversation
/hold |
bc15b90
to
7e9805a
Compare
7e9805a
to
351666b
Compare
52640c5
to
88905d4
Compare
it'd be good to have test case that ensures max inflight is honoured, lgtm otherwise |
a5e4aab
to
efc2894
Compare
/hold cancel |
LGTM label has been added. Git tree hash: 93e93d79444e789873f6a8ec02bd4ed8ca52c7ea
|
afc7039
to
ca47221
Compare
68e759a
to
dc4d302
Compare
/assign @sbueringer for final review |
Getting close, I think |
dc4d302
to
cc82df0
Compare
Signed-off-by: Vince Prignano <vince@prigna.com> tests Signed-off-by: Vince Prignano <vince@prigna.com>
cc82df0
to
fba0337
Compare
/test pull-cluster-api-e2e-main Thank you very much! /lgtm @fabriziopandini fyi, the new field is also supported in CC (see: #10712 (comment)) |
LGTM label has been added. Git tree hash: a8c9362ae8df69e2124741eef69e4e04a01fca54
|
/assign @fabriziopandini @chrischdi @enxebre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.7 |
@vincepri: #10712 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
We're currently always remediating as much as the MachineHealthCheck marks as unhealthy without any waiting. This PR is a first step to fix that issue by adding a Remediation strategy on MachineDeployment which allows to set
maxInFlight
remediations allowed.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area machineset