Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix race condition in TestPatchHelper test #10886

Merged
merged 1 commit into from
Jul 17, 2024
Merged

🐛 Fix race condition in TestPatchHelper test #10886

merged 1 commit into from
Jul 17, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This test has been failing pretty regularly since we merged the test yesterday (#10866)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Fix race condition in TestPatchHelper test
f9b6a48 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@sbueringer
Copy link
Member Author

/assign @chrischdi @fabriziopandini
/cc @troy0820

@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 17, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main

@sbueringer
Copy link
Member Author

Let's run both test jobs a few times and if all is green, let's merge it and check testgrid tomorrow again

chrischdi
chrischdi reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aad0cf79a6343ef67eb18f3346bbf900d7e06fe4

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@chrischdi
Copy link
Member

/hold to run the tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-mink8s-main
/test pull-cluster-api-test-mink8s-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-mink8s-main
/test pull-cluster-api-test-mink8s-main
/hold cancel

(with the new runs we will have 3x in a row)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-main

fabriziopandini
fabriziopandini reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fda8713 into kubernetes-sigs:main Jul 17, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 17, 2024
@sbueringer sbueringer deleted the pr-fix-patch-helper-test branch July 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@vincepri vincepri Awaiting requested review from vincepri

@troy0820 troy0820 Awaiting requested review from troy0820

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini