Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] ✨ Add QPS & burst options & flags for ClusterCacheTracker #10894

Merged

Conversation

jimmidyson
Copy link
Member

Manual cherry-pick of #10880.

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2024
@jimmidyson
Copy link
Member Author

/cc @sbueringer

@jimmidyson
Copy link
Member Author

/area clustercachetracker

@k8s-ci-robot k8s-ci-robot added area/clustercachetracker Issues or PRs related to the clustercachetracker and removed do-not-merge/needs-area PR is missing an area label labels Jul 17, 2024
@sbueringer
Copy link
Member

@jimmidyson PR is fine, please change the commit message to ~ the same as on the original PR

Including PR IDs in commit messages leads to strange effects with our release note generation tool

@jimmidyson
Copy link
Member Author

@sbueringer Updated commit message.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba5c761f95f91723c83e848e89b32408984ba5df

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8927b55 into kubernetes-sigs:release-1.7 Jul 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants