Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 clusterctl: allow to get templates from repository without cluster #2353

Merged
merged 1 commit into from
Feb 18, 2020
Merged

🏃 clusterctl: allow to get templates from repository without cluster #2353

merged 1 commit into from
Feb 18, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
this PR allows to run clusterctl config cluster before a management cluster exists.
Please note that in this case, being impossible to derive parameters values from the cluster, all the required parameters should be provided using flags.

clusterctl config cluster test  --target-namespace default --infrastructure docker:v0.3.0

/area clusterctl
/assing @wfernandes
/assing @vincepri

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2020
vincepri
vincepri approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@vincepri vincepri changed the title ✨clusterctl: allow to get templates from repository without cluster 🏃 clusterctl: allow to get templates from repository without cluster Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@vincepri vincepri added this to the v0.3.0-rc.1 milestone Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit bf7f303 into kubernetes-sigs:master Feb 18, 2020
@fabriziopandini fabriziopandini deleted the clusterctl-get-template-without-cluster branch February 20, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@chuckha chuckha Awaiting requested review from chuckha

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @vincepri