Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Rename Metal3.io provider from Baremetal to Metal3 #2462

Merged
merged 1 commit into from
Mar 4, 2020
Merged

📖 Rename Metal3.io provider from Baremetal to Metal3 #2462

merged 1 commit into from
Mar 4, 2020

Conversation

maelk
Copy link
Contributor

@maelk maelk commented Feb 27, 2020

What this PR does / why we need it:
This PR renames the Metal3.io provider from Baremetal to Metal3 in clusterctl and the documentation

Which issue(s) this PR fixes :
Fixes #2447

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maelk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2020
@maelk
Copy link
Contributor Author

maelk commented Feb 27, 2020

/hold
to give some time for the discussion
/assign @detiber
/cc @vincepri

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020
@maelk maelk mentioned this pull request Feb 27, 2020
Merged
@vincepri vincepri added this to the v0.3.0-rc.3 milestone Feb 27, 2020
@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020
vincepri
vincepri approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@detiber
Copy link
Member

detiber commented Feb 27, 2020

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@vincepri
Copy link
Member

is it ok to unhold or do we want to wait until next week?

@maelk
Copy link
Contributor Author

maelk commented Feb 28, 2020 •
edited
Loading

I would rather put a lazy consensus deadline, to give the metal3.io community time to discuss the extent of the renaming internally. What about next Wednesday ?

@maelk maelk mentioned this pull request Feb 28, 2020
Closed
@ncdc
Copy link
Contributor

ncdc commented Feb 28, 2020

This is async from the 0.3 work, so moving to Next & we can merge after/assuming lazy consensus.

/milestone Next

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.0-rc.3, Next Feb 28, 2020
@Arvinderpal
Copy link
Contributor

Just a general comment: cluster-api-provider-baremetal by itself is insufficient for creating metal3/baremetal clusters/machines. This is in contrast (I believe) to the other providers which for the most part involve defining env variables and are good to go.
Since additional providers can be easily added in the clusterctl config file, would it make more sense to leave this out of the defaults?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2020
@maelk
Copy link
Contributor Author

maelk commented Mar 4, 2020

@detiber I had to rebase, could you please lgtm again ?

@maelk
Copy link
Contributor Author

maelk commented Mar 4, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2020
@detiber
Copy link
Member

detiber commented Mar 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9709769 into kubernetes-sigs:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: Should we rename references to metal3.io from BareMetal Provider to metal3.io instead?
6 participants
@maelk @k8s-ci-robot @vincepri @detiber @ncdc @Arvinderpal