🐛 Validate MHC MaxUnhealthy strings are percentages #2648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It is currently possible to put
{"spec": {"maxUnhealthy": 1}}
and{"spec": {"maxUnhealthy": "1"}}
and get different behaviour within MHC. Within theapps
group types, they validate that the string values are valid percentages before persisting, thus allowing the bug that I hit during the demo today to go unnoticed for such a long time.I've added this validation to the webhook for MHC and this should prevent users from hitting this in the future