🐛 controlplane: Normalise image name for kube-proxy, and validate Kubernetes versions #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
|
/assign |
There was a problem hiding this comment.
@randomvariable thanks!
only one nit from my side, not blocking
vincepri
reviewed
Mar 16, 2020
randomvariable
force-pushed
the
proxy-validation
branch
2 times, most recently
from
7d8622b
to
5e1a887
Compare
|
/retest |
vincepri
reviewed
Mar 16, 2020
randomvariable
force-pushed
the
proxy-validation
branch
from
5e1a887
to
6a920ef
Compare
wfernandes
reviewed
Mar 16, 2020
neolit123
reviewed
Mar 16, 2020
vincepri
reviewed
Mar 16, 2020
vincepri
reviewed
Mar 16, 2020
wfernandes
reviewed
Mar 16, 2020
controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go
Outdated
Show resolved
Hide resolved
randomvariable
force-pushed
the
proxy-validation
branch
4 times, most recently
from
e02be71
to
d66ccbf
Compare
vincepri
reviewed
Mar 16, 2020
controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go
Outdated
Show resolved
Hide resolved
randomvariable
force-pushed
the
proxy-validation
branch
3 times, most recently
from
13ba216
to
59b77f4
Compare
|
@randomvariable +1 to remove wip? |
|
I think so |
randomvariable
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
randomvariable
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ncdc
reviewed
Mar 16, 2020
wfernandes
reviewed
Mar 16, 2020
randomvariable
force-pushed
the
proxy-validation
branch
2 times, most recently
from
80bc61d
to
0357c8d
Compare
ncdc
reviewed
Mar 16, 2020
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
proxy-validation
branch
from
0357c8d
to
f403892
Compare
|
I'm good with this, thanks! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
Normalises the image name for kube-proxy to support build suffixes for versioning.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2689
Marking as WIP as smoke tests are conducted.