-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ util.{Machine,Cluster}ToInfrastructureMapFunc should exclude version when parsing object references #2786
⚠️ util.{Machine,Cluster}ToInfrastructureMapFunc should exclude version when parsing object references #2786
Conversation
Hi @jan-est. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Had a dig through the code to properly understand what's going on here, what used to happen is that you could have two versions for your CRD (eg |
@JoelSpeed that is correct, if you had two different versions on the same contract the objects won't be reconciled properly. Having reconciliation on objects with different API versions is fine because of conversion as you mentioned. |
In which case, everything looks good here :) /lgtm |
/retitle |
/ok-to-test |
/milestone v0.3.3 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan-est, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This bugfix will fix the matching issue discussed in 2775 using match on group kind and not version in.