Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[CAPD] make CAPD ready for self-hosted tests #2904

Merged
merged 1 commit into from
Apr 14, 2020
Merged

✨[CAPD] make CAPD ready for self-hosted tests #2904

merged 1 commit into from
Apr 14, 2020

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR makes it possible to use CAPD for testing CAPI in a self-hosted cluster

Which issue(s) this PR fixes:
Fixes #2903

xref #2753
xref #2637
xref #2636

/assign @vincepri
/assign @sedefsavas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2020
vincepri
vincepri approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-capd-e2e
failure seems related to a timeout, not to the current PR

sedefsavas
sedefsavas reviewed Apr 14, 2020
View reviewed changes
Copy link

@sedefsavas sedefsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise lgtm.

test/infrastructure/docker/api/v1alpha3/dockermachine_types.go Show resolved Hide resolved
test/infrastructure/docker/docker/machine.go
ret := make([]v1alpha4.Mount, 0, len(mounts))
for _, m := range mounts {
ret = append(ret, v1alpha4.Mount{
ContainerPath: m.ContainerPath,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ContainerPath will be optional, do we need to check if containerPath is empty and not create mount if it is empty? or is it a no-op Mount?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to do proper validation, there should be a validating webhook that now is missing in CAPD.
But I think it is acceptable for now and we can iterate in future

test/infrastructure/docker/docker/machine.go Outdated Show resolved Hide resolved
@vincepri
Copy link
Member

/milestone v0.3.4

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 14, 2020
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Apr 14, 2020 •
edited
Loading

@sedefsavas comment addressed, thanks for feedback!

@sedefsavas
Copy link

sedefsavas commented Apr 14, 2020 •
edited
Loading

/lgtm
/hold until tests pass

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@sedefsavas
Copy link

/hold until tests pass

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020
@sedefsavas
Copy link

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0b964b7 into kubernetes-sigs:master Apr 14, 2020
@fabriziopandini fabriziopandini deleted the capd-selfhosted branch April 15, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedefsavas sedefsavas sedefsavas left review comments

@vincepri vincepri vincepri approved these changes

@detiber detiber Awaiting requested review from detiber

Assignees

@vincepri vincepri

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.4
Development

Successfully merging this pull request may close these issues.

Make CAPD support self-hosted
4 participants
@fabriziopandini @k8s-ci-robot @vincepri @sedefsavas