🏃 Remove MachineSet controller Update fallback #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By marking it as optional and omitempty it won't be submitted to the server, we can just rely on it having a default of 0 by virtue of being a value type
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/milestone v0.3.4 |
|
@benmoss Have you run some manual tests with tilt and/or clusterctl to double-check existing functionality isn't breaking after this change? More specifically:
MachineDeployment controller tests also exercise MachineSet, which is why I'm suggesting using a MD. |
|
Will do |
|
Everything seems fine with scale up / scale down / upgrade rollouts 👍 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes some somewhat crufty logic around falling back to using
UpdatewhenPatchfails on MachineSets due to validations. It seems that the patch that is constructed will never containreplicas: 0, so it fails validation because it was a required field.By marking it as optional and omitempty it won't be submitted to the server, we can just rely on it having a default of 0 by virtue of being a Go value type.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1945
/assign @vincepri