-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Add ci-apidiff job #2923
🏃 Add ci-apidiff job #2923
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3e0194d
to
6cf95be
Compare
scripts/ci-apidiff.sh
Outdated
@@ -0,0 +1,28 @@ | |||
#!/bin/bash | |||
|
|||
# Copyright 2018 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate or should it be 2020?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy pasted it, fixed
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, love the idea of proactively testing for breaking api consumers.
Signed-off-by: Vince Prignano <vincepri@vmware.com>
/lgtm |
Signed-off-by: Vince Prignano vincepri@vmware.com