🏃 allow extra args with tilt

[alexeldeib]

Allows extra args from the tilt provider config.

This makes testing things like feature flags much easier. It needs to be in provider config rather than settings so it can be used across all providers (settings files are 1 per invocation I think? but we could change that).

[vincepri]

/approve
/milestone v0.3.4
/assign @detiber

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[detiber]

@alexeldeib thanks for tackling this, a couple of questions related to the kubeadm-bootstrap provider and the developer experience on the changes, but can't wait until we can start taking advantage of feature gates with the tilt-based workflow.

[alexeldeib]

does this actually do anything? I'm not using it AFAIK, but I don't recall if kubeadm-bootstrap specifically uses this value at all

[detiber]

It looks like it's used for adding the watch on MachinePool:

cluster-api/bootstrap/kubeadm/controllers/kubeadmconfig_controller.go

Lines 109 to 116 in 99a95aa

	if feature.Gates.Enabled(feature.MachinePool) {
	builder = builder.Watches(
	&source.Kind{Type: &expv1.MachinePool{}},
	&handler.EnqueueRequestsFromMapFunc{
	ToRequests: handler.ToRequestsFunc(r.MachinePoolToBootstrapMapFunc),
	},
	)
	}

and also in determining the config owner (which is used during the Reconcile method):

cluster-api/bootstrap/util/configowner.go

Lines 95 to 100 in 99a95aa

	if feature.Gates.Enabled(feature.MachinePool) {
	allowedGKs = append(allowedGKs, schema.GroupKind{
	Group: expv1.GroupVersion.Group,
	Kind: "MachinePool",
	})
	}

[alexeldeib]

thanks for the links, probably should have tried a simple ctrl-f 😋

[k8s-ci-robot]

@alexeldeib: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-capd-e2e	476434e	link	/test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[alexeldeib]

/test pull-cluster-api-capd-e2e

[detiber]

/lgtm