Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Disable test Observed Generation in KCP #4466

Merged
merged 1 commit into from
Apr 13, 2021
Merged

🐛 Disable test Observed Generation in KCP #4466

merged 1 commit into from
Apr 13, 2021

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Apr 12, 2021 •
edited
Loading

What this PR does / why we need it:
This PR temporarily disables KCP's test Observed Generation due to flakes under resource starvation; the fix should be worked in testenv/controller runtime (use the live client, fix kubernetes/kubernetes#80609).

Which issue(s) this PR fixes:
Ref #4461

@davideimola PTAL

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2021
@fabriziopandini
Copy link
Member Author

/retest

davideimola
davideimola approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideimola
Copy link
Contributor

Sorry I have did not notice the flakiness in the test while writing it!

@fabriziopandini
Copy link
Member Author

/retest pull-cluster-api-test-main

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-make-main
  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-verify
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

Use /test all to run the following jobs:

  • pull-cluster-api-build-main
  • pull-cluster-api-make-main
  • pull-cluster-api-apidiff-main
  • pull-cluster-api-verify
  • pull-cluster-api-test-main
  • pull-cluster-api-e2e-main

In response to this:

/retest pull-cluster-api-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

1 similar comment
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

yastij
yastij reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@yastij
Copy link
Member

yastij commented Apr 12, 2021

it seems like https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/4466/pull-cluster-api-test-main/1381604712435945472 is failing again. perhaps it needs more time

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@vincepri
Copy link
Member

/test pull-cluster-api-test-main

@sbueringer
Copy link
Member

As far as I can see => lgtm. Not sure about my review comments.

@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 12, 2021
Merged
@CecileRobertMichon
Copy link
Contributor

there is also an attempt to fix it in 589db28

@shysank shysank mentioned this pull request Apr 12, 2021
Closed
@fabriziopandini fabriziopandini force-pushed the fix-test-observed-generation branch 2 times, most recently from fe96536 to 0dcc729 Compare April 12, 2021 21:30
@fabriziopandini fabriziopandini changed the title 🐛 Fix test Observed Generation flakiness in KCP 🐛 Disable test Observed Generation in KCP Apr 12, 2021
@fabriziopandini
Copy link
Member Author

the fix should be worked in testenv/controller runtime (use the live client, fix kubernetes/kubernetes#80609), so I'm temporarily disabling the test to unblock PRs

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021
MarcelMue
MarcelMue reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@sbueringer
Copy link
Member

/lgtm

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Apr 13, 2021 •
edited
Loading

/approve
to reduce test flakiness

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit dc27cdc into kubernetes-sigs:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 13, 2021
@BenTheElder
Copy link
Member

BenTheElder commented Apr 13, 2021 •
edited
Loading

Please be careful with "fix #..." as github will close the issue even across organizations on merge and considers it a feature 😅

@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 13, 2021
Merged
@fabriziopandini fabriziopandini deleted the fix-test-observed-generation branch April 15, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@yastij yastij yastij left review comments

@MarcelMue MarcelMue MarcelMue left review comments

@davideimola davideimola davideimola approved these changes

@detiber detiber Awaiting requested review from detiber

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@sbueringer sbueringer

@yastij yastij

@MarcelMue MarcelMue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Decoding should not clear apiVersion/kind
9 participants
@fabriziopandini @davideimola @k8s-ci-robot @yastij @vincepri @sbueringer @CecileRobertMichon @BenTheElder @MarcelMue