Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] 🌱 Update kubebuilder envtest (1.25.2 -> 1.26.0) #7864

Conversation

aniruddha2000
Copy link
Contributor

@aniruddha2000 aniruddha2000 commented Jan 6, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #7671

@kubernetes-sigs/cluster-api-release-team

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @aniruddha2000!
For future reference you can use the cherry-pick bot to do this work automatically as here: #7717 (comment)

Some times it might not work and you'll have to open the PR manually, but it does save a good bit of the copy-past of cherry-picks 🙂

@aniruddha2000
Copy link
Contributor Author

@killianmuldoon thanks for the information. From future I will try to do it with bot first

@sbueringer sbueringer changed the title 🌱 Update kubebuilder envtest (1.25.2 -> 1.26.0) for release 1.2 [release-1.2] 🌱 Update kubebuilder envtest (1.25.2 -> 1.26.0) Jan 9, 2023
@sbueringer sbueringer mentioned this pull request Jan 9, 2023
13 tasks
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 501a5b42b0f92b35ce9843d38ff5e1b849e7a462

@sbueringer
Copy link
Member

@aniruddha2000 Just fyi. I changed "Fixes" to "Part of". Please only use "Part of" if a PR closes a sub-task of an issue. Otherwise GitHub closes the whole issue :)

@k8s-ci-robot k8s-ci-robot merged commit 96e878e into kubernetes-sigs:release-1.2 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants