Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update controller tools to v0.11.4 #8547

Merged
merged 1 commit into from
Apr 24, 2023
Merged

🌱 Update controller tools to v0.11.4 #8547

merged 1 commit into from
Apr 24, 2023

Conversation

killianmuldoon
Copy link
Contributor

Bump controller tools and regenerate based on the new version.

Release notes: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.11.4
Fixes #8546

@killianmuldoon
Update controller tools to v0.11.4
9296872 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
killianmuldoon commented Apr 24, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick release-1.3

Probably safer and easier to cherry-pick this manually

furkatgofurov7
furkatgofurov7 reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

How about release-1.4 (I saw only the command for cherry-picking it to release-1.3)

@killianmuldoon
Copy link
Contributor Author

How about release-1.4 (I saw only the command for cherry-picking it to release-1.3)

I think we should cherry pick this but do so manually so we get the correct generation for each branch.

@sbueringer
Copy link
Member

No strong opinions on how we cherry-pick as long as we do it :)

/lgtm
/approve

/hold
pending green tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d790990b974803d52b19d2ddbad0f99efb061af3

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@killianmuldoon
Copy link
Contributor Author

pending green tests

Do you want to do a full run on this PR?

@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023 •
edited
Loading

Regular ones are fine

/hold cancel

Not sure what the problem with the cla label is

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@sbueringer
Copy link
Member

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2023
@sbueringer
Copy link
Member

We had some problems with tests before. I assume the hook component of Prow was down before.

@k8s-ci-robot k8s-ci-robot merged commit 6c6b91a into kubernetes-sigs:main Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 24, 2023
@johannesfrey
Copy link
Contributor

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Bump controller-tools to v0.11.4
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @johannesfrey @furkatgofurov7