-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure ALWAYS_BUILD_KIND_IMAGES is defaulted correctly in ci script #8873
🐛 Ensure ALWAYS_BUILD_KIND_IMAGES is defaulted correctly in ci script #8873
Conversation
/cherry-pick release-1.3 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.2 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be cherry-picked to every branch that has this env variable added in
scripts/ci-e2e-lib.sh
Outdated
@@ -101,11 +101,14 @@ k8s::resolveVersion() { | |||
kind::prepareKindestImage() { | |||
local version=$1 | |||
|
|||
# ALWAYS_BUILD will default to false if unset. | |||
ALWAYS_BUILD="${ALWAYS_BUILD_KIND_IMAGES:-"false"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be necessary to use a different env var name on the left side
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
13d137e
to
e8fc1a4
Compare
Thx! |
LGTM label has been added. Git tree hash: 4e8e1272c7776d837d8dffeed8ec7b01b8158695
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: new pull request created: #8874 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8875 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8876 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area ci |
Issue introduced in #8859 due to the use of a potentially unbound variable in the bash script. This variable should default to false if unset in the variables passed in to the script.