-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Protect well know registry from accidental push during tilt up #8930
🌱 Protect well know registry from accidental push during tilt up #8930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of spelling nits.
The behaviour here is that setting this value only matters if there's no default registry.
e6a1637
to
d382fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for following up on this!!
d382fb0
to
dc87b86
Compare
dc87b86
to
f192b7b
Compare
Sorry last one :) |
856a2d0
to
54586ea
Compare
54586ea
to
cb5f429
Compare
Tested locally. All works! /lgtm |
LGTM label has been added. Git tree hash: 9be614ecf4d3a40e0920e3c4535db2cdf62b34fc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area devtools |
What this PR does / why we need it:
This PR makes sure that if you are using tilt up without a local registry, you can't accidentally push to well know repository like our staging repo
cc @sbueringer