-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 hack/observability: skip preload images on non-kind clusters #8931
🌱 hack/observability: skip preload images on non-kind clusters #8931
Conversation
/assign @fabriziopandini @killianmuldoon @ykakarap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one nit
0245cf4
to
1c8d3a3
Compare
Signed-off-by: Stefan Büringer buringerst@vmware.com
1c8d3a3
to
598a10b
Compare
@fabriziopandini @killianmuldoon PTAL :) (cc @ykakarap pushed the same version on the scale branch, so the flag is not needed anymore) |
/lgtm |
LGTM label has been added. Git tree hash: 2473293dd7a183515bf90a7a2b56ec2a0faf1396
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area devtools |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #