-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Allow duplicate objects in Tiltfile #9302
Conversation
Co-authored-by: Dario Tranchitella <dario@tranchitella.eu>
|
Hi @prometherion. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please check the CLA error + the PR title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/area devtools
/retitle 🐛 Allow duplicate objects in Tiltfile
/check-cla @prometherion have you signed the CLA? Not sure if it's bugging out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for fixing this!
LGTM label has been added. Git tree hash: b745cbfda1a333feef332117678d75f05823f294
|
Looks like the PR is currently co-authored. See #9302 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
Sorry for the delay. I have signed it. |
No worries /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Support for duplicated resources when debugging with Tilt.
Providers could require add-ons which have duplicated Namespace objects, thus breaking the Tilt setup.
Which issue(s) this PR fixes:
Fixes #9300