Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Guess GVK for unstructured list items not in scheme #2216

Closed
wants to merge 2 commits into from
Closed

✨ Guess GVK for unstructured list items not in scheme #2216

wants to merge 2 commits into from

Conversation

hiddeco
Copy link

@hiddeco hiddeco commented Feb 28, 2023

Fixes #2171

@hiddeco
Unstructured list doesn't set unrecognized GVK
89c0643 
Running this without the subsequent patch applied proofs the GVK on
unstructured list items currently isn't propagated with an unsafe
guess, which would improve ease of consumption.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco
Guess GVK unstructured list items not in scheme
7dc5b28 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hiddeco
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @hiddeco!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @hiddeco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2023
@hiddeco
Copy link
Author

hiddeco commented Feb 28, 2023

Interesting enough 89c0643 now seems to pass without fixes compared to original state before I rebased against main, which does not seem to happen for hiddeco@3391a83 against release-0.14.

alvaroaleman
alvaroaleman reviewed Mar 1, 2023
View reviewed changes
pkg/client/client.go
// If the scheme doesn't recognize the GVK, it will not be set on
// the list items. We can however produce an unsafe guess which
// will work for most cases, and eases consumption.
itemGVK := schema.GroupVersionKind{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is set in the structured case? I thought this is never the case due to kubernetes/kubernetes#80609

@FillZpp
Copy link
Contributor

FillZpp commented Mar 1, 2023

Guess GVK for unstructured list items not in scheme

I remember the return items of unstructured list should already have GVK, no matter the type is in scheme or not.

@hiddeco
Copy link
Author

hiddeco commented Mar 1, 2023

Closing this until I have more time to get to the bottom of it, thanks both.

@hiddeco hiddeco closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstructured client's List does not propagate GVK to items
4 participants
@hiddeco @k8s-ci-robot @FillZpp @alvaroaleman