Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v1alpha2 config version #143

Merged

Conversation

fabriziopandini
Copy link
Member

This PR adds v1alpha2 config version.

v1alpha2 currently is copy/paste from v1alpha1, but in following PRs it will be modified for supporting multi node as defined #130.

Fuzzer tests were added to make sure conversion works.
Ending test for the new version were added as well

Note for reviewers
To make everyhing work it was necessary to update some dependencies, and this accounts the size of the PR 😭(all deps are in a separated commit) :

  • k8s.io/apimachinery and k8s.io/code-generator now are both from master branch (before k8s.io/code-generator was pinned to release-v1.11)
  • vendored k8s.io/apimachinery, k8s.io/code-generator and k8s.io/gengo where updated to get a consistent set of dependencies after the switch to klog

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 29, 2018
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fabriziopandini
LGTM on a quick pass.

-verify needs hack/update-deps.sh.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ignored the code generated by conversion-gen. 👍

@fabriziopandini
Copy link
Member Author

Updated 2nd commits only (gopkg +external dependencies) to pass verify

@alejandrox1
Copy link
Contributor

/test pull-kind-conformance-parallel

2 similar comments
@fabriziopandini
Copy link
Member Author

/test pull-kind-conformance-parallel

@fabriziopandini
Copy link
Member Author

/test pull-kind-conformance-parallel

@fabriziopandini
Copy link
Member Author

@BenTheElder failures in conformance test IMO are unrelated to this PR.
How can I get around this?

@alejandrox1
Copy link
Contributor

/retest

@BenTheElder
Copy link
Member

Kubernetes master is broken currently (CNI version mismatch) kubernetes/kubernetes#71629 to fix.

Will loop back around to kind PRs after sorting upstream.

@BenTheElder
Copy link
Member

/retest

@fabriziopandini fabriziopandini mentioned this pull request Dec 4, 2018
@munnerz
Copy link
Member

munnerz commented Dec 4, 2018

This looks good to me, and is now passing tests too 😄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2018
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2018
@BenTheElder
Copy link
Member

/retest

@BenTheElder
Copy link
Member

This got flakier in recent releases too:

I1206 03:08:40.329] Summarizing 1 Failure:
I1206 03:08:40.329] 
I1206 03:08:40.329] [Fail] [k8s.io] [sig-node] Events [It] should be sent by kubelets and the scheduler about pods scheduling and running  [Conformance] 

:/
/retest

@k8s-ci-robot k8s-ci-robot merged commit bd07450 into kubernetes-sigs:master Dec 6, 2018
@fabriziopandini fabriziopandini deleted the v1alpha2-config branch December 15, 2018 08:45
stg-0 pushed a commit to stg-0/kind that referenced this pull request Jun 20, 2023
…ng_subnets

 [EOS-11345][EKS] El CIDR secundario para Pods falla con infra custom según el órden de las subnets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants