Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadog plugin to index #727

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

L3n41c
Copy link
Contributor

@L3n41c L3n41c commented Jul 27, 2020

Add the datadog plugin.

The datadog kubectl plugin provides useful utilities to operate datadog-agent components via the Datadog Operator and the DatadogAgent CRD.

Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com>
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 27, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @L3n41c!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2020
@ahmetb
Copy link
Member

ahmetb commented Jul 27, 2020

@L3n41c To clarify, are you submitting this at an official capacity, correct? If the binary explicitly prepared as a kubectl plugin and would your docs installation Krew as an install method as well?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 27, 2020
@L3n41c
Copy link
Contributor Author

L3n41c commented Jul 28, 2020

Hello @ahmetb,

Indeed, I’m pushing this PR as a Datadog employee.
Our plugin already has the instructions for being installed as a krew plugin: https://github.com/DataDog/datadog-operator/blob/master/docs/kubectl-plugin.md
I’ve prepared a PR to update the instructions once the datadog plugin will referenced inside the krew index: DataDog/datadog-operator#126.

@ahmetb
Copy link
Member

ahmetb commented Jul 28, 2020

/lgtm
/approve
Welcome to Krew!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, L3n41c

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit f821d33 into kubernetes-sigs:master Jul 28, 2020
@L3n41c L3n41c deleted the add_datadog branch July 28, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants