Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client-go auth plugins #91

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

pyrsson
Copy link
Contributor

@pyrsson pyrsson commented Feb 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds support for clusters using any of the client-go auth plugins like oidc based on these docs: client-go examples

Fixes validation of CRDs when connected to a cluster with oidc for example:

$ kubectl-validate ./test-with-crds.yaml

../test-with-crds.yaml...ERROR
failed to retrieve validator: failed to locate OpenAPI spec for GV: bitnami.com/v1alpha1
failed to retrieve validator: failed to locate OpenAPI spec for GV: bitnami.com/v1alpha1
failed to retrieve validator: failed to locate OpenAPI spec for GV: minio.min.io/v2
Error: validation failed
# with auth plugins
 $ kubectl-validate ./test-with-crds.yaml

./test-with-crds.yaml...OK

Which issue(s) this PR fixes:

Didn't open an issue, hope that's ok.

Special notes for your reviewer:

First ever contribution, please let me know if there's something I missed or need to change.

Does this PR introduce a user-facing change?

Added support for client-go auth plugins

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2024
Copy link

linux-foundation-easycla bot commented Feb 22, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @pyrsson!

It looks like this is your first PR to kubernetes-sigs/kubectl-validate 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubectl-validate has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2024
@eddycharly
Copy link
Contributor

LGTM but i wonder if we can have a test for that 🤔

@pyrsson
Copy link
Contributor Author

pyrsson commented Feb 27, 2024

LGTM but i wonder if we can have a test for that 🤔

I could give it a go, but I'm not entirely sure what the tests should cover. My understanding is that there is fairly little value in writing tests for library functionality, but I could be wrong.

Do you have a suggestion for what to test in kubeconfig.go?

@alexzielenski
Copy link
Contributor

/lgtm
/approve

From a glance it looks like adding a good test for this requires infra we dont have to stand up a fake cluster requiring the plugin. Since this is a single line addition simply to link the library I think it is ok to add

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, pyrsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c10cee into kubernetes-sigs:main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants