add tests for file:// without git suffix

api/internal/git/repospec.go

@@ -140,13 +140,12 @@ func parseGitURL(n string) (
 		if idx := strings.Index(n, "//"); idx > 0 {
 			orgRepo = n[:idx]
 			n = n[idx+2:]
-		} else if q := strings.Index(n, "?"); q != -1 {
-			orgRepo = n[:q]
-			n = n[q:]
-		} else {
-			orgRepo = n
+			path, gitRef, gitTimeout, gitSubmodules = peelQuery(n)
+			return
 		}
 		path, gitRef, gitTimeout, gitSubmodules = peelQuery(n)
+		orgRepo = path
+		path = ""
 		return
 	}
 

api/internal/git/repospec_test.go

@@ -359,6 +359,16 @@ func TestNewRepoSpecFromUrl_Smoke(t *testing.T) {
 				GitSuffix: ".git",
 			},
 		},
+		{
+			name:      "t21",
+			input:     "file:///a/b/c/someRepo",
+			cloneSpec: "file:///a/b/c/someRepo",
+			absPath:   notCloned.String(),
+			repoSpec: RepoSpec{
+				Host:    "file://",
+				OrgRepo: "/a/b/c/someRepo",
+			},
+		},
 	}
 	for _, tc := range testcases {
 		t.Run(tc.name, func(t *testing.T) {

api/krusty/remoteloader_test.go

@@ -27,13 +27,15 @@ func TestRemoteLoad_LocalProtocol(t *testing.T) {
 	type testRepos struct {
 		root          string
 		simple        string
+		noSuffix      string
 		multiBaseDev  string
 		withSubmodule string
 	}
 
 	// creates git repos under a root temporary directory with the following structure
 	// root/
 	//   simple.git/			- base with just a pod
+	//   nosuffix/				- same as simple.git/ without the .git suffix
 	//   multibase.git/			- base with a dev overlay
 	//   with-submodule.git/	- includes `simple` as a submodule
 	//     submodule/			- the submodule referencing `simple
@@ -74,6 +76,7 @@ EOF
 	git commit -am "image change"
 	git checkout main
 )
+cp -r $ROOT/simple.git $ROOT/nosuffix
 cp -r testdata/remoteload/multibase $ROOT/multibase.git
 (
 	cd $ROOT/multibase.git
@@ -90,8 +93,10 @@ cp -r testdata/remoteload/multibase $ROOT/multibase.git
 )
 `, root))
 		return testRepos{
-			root:          root,
+			root: root,
+			// The strings below aren't currently used, and more serve as documentation.
 			simple:        "simple.git",
+			noSuffix:      "nosuffix",
 			multiBaseDev:  "multibase.git",
 			withSubmodule: "with-submodule.git",
 		}
@@ -124,6 +129,14 @@ spec:
 			kustomization: `
 resources:
 - file://$ROOT/simple.git
+`,
+			expected: simpleBuild,
+		},
+		{
+			name: "without git suffix",
+			kustomization: `
+resources:
+- file://$ROOT/nosuffix
 `,
 			expected: simpleBuild,
 		},
@@ -132,6 +145,14 @@ resources:
 			kustomization: `
 resources:
 - file://$ROOT/multibase.git/dev
+`,
+			expected: multibaseDevExampleBuild,
+		},
+		{
+			name: "has path without git suffix",
+			kustomization: `
+resources:
+- file://$ROOT/multibase//dev
 `,
 			expected: multibaseDevExampleBuild,
 		},