-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some CI tasks should include verification that no diff was produced #4977
Comments
@KnVerey: This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
Hi @KnVerey, I am quite new to the codebase and would like to clarify on the requirements and familiarise myself with the repo.
|
I believe that To answer the rest of your questions, I think You can probably define a new make target like |
Super! Thanks @natasha41575 for the insights I think of having the same strategy for Opt 1: All done within Makefile, calling a simple git command, but the check will be very simple and it will not cover any intelligent logic, plus it will need the CI environment to have git Alternatively, if we aim to check the file integrity, we can use built-in commands like Wdyt? |
One more thing, what kind of handling is expected upon finding diff? |
As per last standup meeting, we go with option 2 (to have a different module to check diff, utilising gorepomod) and we throwing error is expected upon finding diff. |
Resolved by #5303 |
Thanks so much @antoooks! |
make test-go-mod
is run part of presubmit (though we're considering replacing it), but it is not very effective on its own as a CI check, because it passes even if the command makes uncommitted changesgo work sync
as well, now that we're using workspace mode.make generate-kustomize-builtin-plugins
is currently run at all. It should be run, with an assertion that it doesn't generate a diff. This implies we're relying on manual reviews of the generated files + e2e tests (typically Krusty tests) having enough coverage to detect unintended drift.The text was updated successfully, but these errors were encountered: