Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CheckDiffOnFile in git module on gorepomod #5302

Closed

Conversation

antoooks
Copy link
Contributor

  • Add CheckDiffOnFile function on git module to check diff
  • Add tests for CheckDiffOnFile

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antoooks
Once this PR has been reviewed and has the lgtm label, please assign annasong20 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @antoooks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 31, 2023
@antoooks antoooks marked this pull request as draft August 31, 2023 08:09
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@antoooks
Copy link
Contributor Author

Hi @natasha41575 , would you care to elaborate how to access git modules on gorepomod from Makefile? Do I need to release it before so?

@antoooks antoooks marked this pull request as ready for review September 7, 2023 15:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
@antoooks
Copy link
Contributor Author

Hi @natasha41575 , would you care to elaborate how to access git modules on gorepomod from Makefile? Do I need to release it before so?

hi @koba1t, seeking your advice, and maybe you know stuff about this module. Since we use go modules I think this module (gorepomod) may not work anymore with the current repo state right?

In that case I should go with a simpler option by executing the diff checking on Makefile directly

@koba1t
Copy link
Member

koba1t commented Sep 14, 2023

Hi @antoooks
Thanks for your contribution.
I'm not familiar with this problem and don't know why you added this function.
So, Could you add any context as to why you made this PR or add a link for the issue that you want to resolve?

@antoooks
Copy link
Contributor Author

antoooks commented Sep 14, 2023

Hi @antoooks Thanks for your contribution. I'm not familiar with this problem and don't know why you added this function. So, Could you add any context as to why you made this PR or add a link for the issue that you want to resolve?

@koba1t Yes, absolutely! This PR is part of two PRs that addresses issue #4977, the other one being #5303. In the comment, I presented 2 ways of integrating the diff check, then on the previous standup meeting, it is decided that we should try option 2 of implementing the diff check with a separate module, @natasha41575 suggested that I should implement it in gorepomod module because they have collections of git commands that the repo is using. However we also concluded in the same meeting, that if we sees that this option is unsuitable after trying, we should go with option 1 which means we implement everything using simple commands on the plugins Makefile.

Hope that clarifies, let me know if you need anymore on the context :)

@antoooks
Copy link
Contributor Author

Closing, as we have settled into implementing all checks on Makefile instead. Refer to #5303

@antoooks antoooks closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants