-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CheckDiffOnFile in git module on gorepomod #5302
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: antoooks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @antoooks. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @natasha41575 , would you care to elaborate how to access |
hi @koba1t, seeking your advice, and maybe you know stuff about this module. Since we use go modules I think this module ( In that case I should go with a simpler option by executing the diff checking on Makefile directly |
Hi @antoooks |
@koba1t Yes, absolutely! This PR is part of two PRs that addresses issue #4977, the other one being #5303. In the comment, I presented 2 ways of integrating the diff check, then on the previous standup meeting, it is decided that we should try option 2 of implementing the diff check with a separate module, @natasha41575 suggested that I should implement it in Hope that clarifies, let me know if you need anymore on the context :) |
Closing, as we have settled into implementing all checks on Makefile instead. Refer to #5303 |
CheckDiffOnFile
function on git module to check diffCheckDiffOnFile