Merge pull request #1255 from hangscer8/clean_ticker

Stop ticker in time to avoid memory leak
kubernetes-sigs · Jul 6, 2023 · 9a108c0 · 9a108c0
2 parents f02d172 + 698031f
commit 9a108c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/pkg/nfd-topology-gc/nfd-nrt-gc.go b/pkg/nfd-topology-gc/nfd-nrt-gc.go
@@ -146,6 +146,7 @@ func (n *topologyGC) runGC() {
 // periodicGC runs garbage collector at every gcPeriod to make sure we haven't missed any node
 func (n *topologyGC) periodicGC(gcPeriod time.Duration) {
 	gcTrigger := time.NewTicker(gcPeriod)
+	defer gcTrigger.Stop()
 	for {
 		select {
 		case <-gcTrigger.C:

diff --git a/pkg/nfd-topology-updater/kubeletnotifier/kubeletnotifier.go b/pkg/nfd-topology-updater/kubeletnotifier/kubeletnotifier.go
@@ -70,6 +70,7 @@ func (n *Notifier) Run() {
 	timeEvents := make(<-chan time.Time)
 	if n.sleepInterval > 0 {
 		ticker := time.NewTicker(n.sleepInterval)
+		defer ticker.Stop()
 		timeEvents = ticker.C
 	}