Skip to content

Commit

Permalink
Merge pull request #1297 from marquiz/devel/topology-updater-version
Browse files Browse the repository at this point in the history
topology-updater: make -version always runnable
  • Loading branch information
k8s-ci-robot committed Aug 28, 2023
2 parents e1f90a2 + 5ba8d14 commit a658c54
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions cmd/nfd-topology-updater/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,8 @@ var DefaultKubeletStateDir = path.Join(string(hostpath.VarDir), "lib", "kubelet"
func main() {
flags := flag.NewFlagSet(ProgramName, flag.ExitOnError)

printVersion := flags.Bool("version", false, "Print version and exit.")

args, resourcemonitorArgs := parseArgs(flags, os.Args[1:]...)

if *printVersion {
fmt.Println(ProgramName, version.Get())
os.Exit(0)
}

// Assert that the version is known
if version.Undefined() {
klog.InfoS("version not set! Set -ldflags \"-X sigs.k8s.io/node-feature-discovery/pkg/version.version=`git describe --tags --dirty --always`\" during build or run.")
Expand All @@ -75,6 +68,7 @@ func main() {

func parseArgs(flags *flag.FlagSet, osArgs ...string) (*topology.Args, *resourcemonitor.Args) {
args, resourcemonitorArgs := initFlags(flags)
printVersion := flags.Bool("version", false, "Print version and exit.")

_ = flags.Parse(osArgs)
if len(flags.Args()) > 0 {
Expand All @@ -83,6 +77,11 @@ func parseArgs(flags *flag.FlagSet, osArgs ...string) (*topology.Args, *resource
os.Exit(2)
}

if *printVersion {
fmt.Println(ProgramName, version.Get())
os.Exit(0)
}

if len(resourcemonitorArgs.KubeletConfigURI) == 0 {
nodeAddress := os.Getenv("NODE_ADDRESS")
if len(nodeAddress) == 0 {
Expand Down

0 comments on commit a658c54

Please sign in to comment.