Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.12.1 #1035

Closed
24 tasks done
marquiz opened this issue Jan 16, 2023 · 11 comments
Closed
24 tasks done

Release v0.12.1 #1035

marquiz opened this issue Jan 16, 2023 · 11 comments
Assignees

Comments

@marquiz
Copy link
Contributor

marquiz commented Jan 16, 2023

Release Checklist

  • All OWNERS must LGTM the release proposal
  • Verify that the changelog in this issue is up-to-date
  • For major releases (v0.$MAJ.0) create new release branch
    • an OWNER creates a vanilla release branch with
      git branch release-0.$MAJ master
    • An OWNER pushes the new release branch with
      git push release-0.$MAJ
    • Create Prow pre-submit job configuration for the new release branch in K8s
      test-infra, submit a PR
    • Wait for the test-infra Prow config PR to be merged
  • Run hack/prepare-release.sh $VERSION to turn references to point to the upcoming release
    (README, deployment templates, docs configuration, test/e2e flags), submit a PR against the release branch
  • An OWNER prepares a draft release
    • Create a draft release at Github releases page
    • Write the change log into the draft release
    • Upload release artefacts generated by prepare-release.sh script above to the draft release
  • An OWNER runs
    git tag -s $VERSION
    and inserts the changelog into the tag description.
  • An OWNER pushes the tag with
    git push $VERSION
  • Submit a PR against k8s.io, updating registry.k8s.io/images/k8s-staging-nfd/images.yaml to promote the container images (both "full" and "minimal" variants) to production
  • Wait for the PR to be merged and verify that the image (registry.k8s.io/nfd/node-feature-discovery:$VERSION) is available.
  • Publish the draft release prepared at the Github releases page
    which will also trigger a Helm repo index update to add the latest release
  • Add a link to the tagged release in this issue.
  • Send an announcement email to dev@kubernetes.io with the subject [ANNOUNCE] node-feature-discovery $VERSION is released
  • Add a link to the release announcement in this issue
  • For a major release (or a point release of the latest major release), update README in master branch
    • Update references e.g. by running hack/prepare-release.sh $VERSION but only committing README.md, and,
      submit a PR
    • Wait for the PR to be merged
  • For a major release, create an unannotated devel tag in the master branch, on the first commit that gets merged after the release branch has been created (presumably the README update commit above), and, push the tag:
    DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL master && git push $DEVEL
    This ensures that the devel builds on the master branch will have a meaningful version number.
  • Close this issue

Changelog

This is a patch release to fix problems with nfd-master readiness and liveness probes that caused it to be killed when NodeFeature API was enabled.

List of PRs

@marquiz
Copy link
Contributor Author

marquiz commented Jan 16, 2023

Fix to #1032 would deserve a patch release, I think

@fmuyassarov
Copy link
Member

+1

@marquiz
Copy link
Contributor Author

marquiz commented Jan 17, 2023

ping @zvonkok @Ethyling @adrianchiris

@jjacobelli
Copy link
Contributor

/lgtm

2 similar comments
@adrianchiris
Copy link
Contributor

/lgtm

@ArangoGutierrez
Copy link
Contributor

/lgtm

@ArangoGutierrez
Copy link
Contributor

add: #1040

@marquiz
Copy link
Contributor Author

marquiz commented Jan 17, 2023

add: #1040

I already tagged but that change can be takin into the release artefacts

@marquiz
Copy link
Contributor Author

marquiz commented Jan 18, 2023

Release announcement:
https://groups.google.com/a/kubernetes.io/g/dev/c/Di_PigPMNws

GitHub release page:
https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.12.1

@marquiz
Copy link
Contributor Author

marquiz commented Jan 19, 2023

Declare this done
/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closing this issue.

In response to this:

Declare this done
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants