-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hardware vendor detection #1057
Comments
Hmm, I'm not sure if there is such unambiguous vendor information in general, as the system can be composed of components from various vendors 🧐 But what we could probably actually do is detect dmi information from /help |
@marquiz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ozhuraki |
Add reading vendor information from /sys/devices/virtual/dmi/id/sys_vendor Closes kubernetes-sigs#1057 Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
What would you like to be added:
I think it would be good to allow NFD to discover the underlying hardware that the system is running on. This can be useful in bare metal environments where you may have a system that's running HP hardware, or Dell hardware and you would need to run specific things on specific systems
Why is this needed:
In my use case, let's say I want to run
dellhw_exporter
only on systems which use Dell hardware, I don't have a way with NFD to detect this out of the box.The text was updated successfully, but these errors were encountered: