Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hardware vendor detection #1057

Closed
mnaser opened this issue Feb 13, 2023 · 3 comments · Fixed by #1574
Closed

Add support for hardware vendor detection #1057

mnaser opened this issue Feb 13, 2023 · 3 comments · Fixed by #1574
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mnaser
Copy link
Contributor

mnaser commented Feb 13, 2023

What would you like to be added:
I think it would be good to allow NFD to discover the underlying hardware that the system is running on. This can be useful in bare metal environments where you may have a system that's running HP hardware, or Dell hardware and you would need to run specific things on specific systems

Why is this needed:
In my use case, let's say I want to run dellhw_exporter only on systems which use Dell hardware, I don't have a way with NFD to detect this out of the box.

@mnaser mnaser added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2023
@marquiz
Copy link
Contributor

marquiz commented Feb 14, 2023

Hmm, I'm not sure if there is such unambiguous vendor information in general, as the system can be composed of components from various vendors 🧐 But what we could probably actually do is detect dmi information from /sys/devices/virtual/dmi/id/*. For example, /sys/devices/virtual/dmi/id/sys_vendor would probably have the information you're after. We could have all the attributes from there as raw features that could be consumed by NodeFeatureRules to create custom labels. We could also create present some of those as "built-in" labels that would be always created by NFD.

/help

@k8s-ci-robot
Copy link
Contributor

@marquiz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Hmm, I'm not sure if there is such unambiguous vendor information in general, as the system can be composed of components from various vendors 🧐 But what we could probably actually do is detect dmi information from /sys/devices/virtual/dmi/id/*. For example, /sys/devices/virtual/dmi/id/sys_vendor would probably have the information you're after. We could have all the attributes from there as raw features that could be consumed by NodeFeatureRules to create custom labels. We could also create present some of those as "built-in" labels that would be always created by NFD.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 14, 2023
@ozhuraki
Copy link
Contributor

/assign @ozhuraki

ozhuraki added a commit to ozhuraki/node-feature-discovery that referenced this issue Jan 30, 2024
Add reading vendor information from /sys/devices/virtual/dmi/id/sys_vendor

Closes kubernetes-sigs#1057

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants