Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: fix mistake in ginkgo focus #1000

Merged
merged 1 commit into from
Dec 14, 2022
Merged

test/e2e: fix mistake in ginkgo focus #1000

merged 1 commit into from
Dec 14, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 14, 2022

Leftover from development that got accidentally merged in 43910e6

@marquiz
test/e2e: fix mistake in ginkgo focus
f04e1a9 
Leftover from development that got accidentally merged in
43910e6
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit f04e1a9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/639a2b5d9dd22900088c0b22
😎 Deploy Preview https://deploy-preview-1000--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 14, 2022

/assign @fmuyassarov @ArangoGutierrez

ArangoGutierrez
ArangoGutierrez approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0529e518d9a97cb2ff249f13ba31b9868d26cc1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 33e44d5 into kubernetes-sigs:master Dec 14, 2022
@marquiz marquiz deleted the fixes/e2e branch December 14, 2022 20:20
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @k8s-ci-robot @ArangoGutierrez @fmuyassarov