test/e2e: drop pod security enforcement label from the test namespace #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/assign @fmuyassarov |
k8s-ci-robot
added
the
size/XS
Drop the pod-security.kubernetes.io/enforce label from the test namespace, i.e. remove pod security admission enforcement. NFD-worker uses restricted host mounts (/sys) etc so pod creation fails even in privileged mode if pod security admission enforcement is enabled.
marquiz
force-pushed
the
devel/e2e-podsecurity
branch
from
21c01dd
to
7b2add4
Compare
|
Fixed typos in the commit msg |
fmuyassarov
reviewed
Dec 15, 2022
There was a problem hiding this comment.
I'm pretty sure this will work but I would like to test it.
Without this, you can run into issue like this
<*errors.StatusError | 0xc000b5bf40>: {
ErrStatus: {
TypeMeta: {Kind: "", APIVersion: ""},
ListMeta: {
SelfLink: "",
ResourceVersion: "",
Continue: "",
RemainingItemCount: nil,
},
Status: "Failure",
Message: "pods \"nfd-worker-c42c228b-e2b8-483e-aefc-810068dcc450\" is forbidden: violates PodSecurity \"restricted:latest\": restricted volume types (volumes \"host-boot\", \"host-os-release\", \"host-sys\", \"host-usr-lib\", \"host-usr-src\" use restricted volume type \"hostPath\")",
Reason: "Forbidden",
Details: {
Name: "nfd-worker-c42c228b-e2b8-483e-aefc-810068dcc450",
Group: "",
Kind: "pods",
UID: "",
Causes: nil,
RetryAfterSeconds: 0,
},
Code: 403,
},
}
pods "nfd-worker-c42c228b-e2b8-483e-aefc-810068dcc450" is forbidden: violates PodSecurity "restricted:latest": restricted volume types (volumes "host-boot", "host-os-release", "host-sys", "host-usr-lib", "host-usr-src" use restricted volume type "hostPath")
occurred
In [It] at: /home/fmuyassarov/go/src/node-feature-discovery/test/e2e/node_feature_discovery.go:245
Please do. I verified this on latest minikube with k8s v1.25. |
fmuyassarov
approved these changes
Dec 16, 2022
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f98467a487965eaad4f83f0c0b06f728bc3b869b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the pod-security.kubernetes.io/enforce label from the test namespace, i.e. remove pod security admission enforcement. NFD-worker uses restricted host mounts (/sys) etc so pod creation fails even in privileged mode if pod security admission enforcement is enabled.